openbsc[master]: lchan: Release channel in case of late activation ack

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Oct 31 00:36:59 UTC 2016


Patch Set 4: Code-Review+1

tested with sysmobts and TCH/F_TCH/H_PDCH timeslots:
patch set 3 ended up never re-activating PDCH, so tweaked the patch as outlined in my long comment, which turns out to be correct.

Also some cosmetic tweaks:
* name the flag 'do_release' instead of 'do_free'.
* say 'Releasing' with 'ing' to match rsl_rx_rf_chan_rel_ack().
* use local 'ts' var.

BTW, the IPACC style dyn TS should work as well because a PDCH act is sent from rsl_rx_rf_chan_rel_ack().

Of course with any other BTS type than sysmobts, these situations will always result in a permanently broken lchan.

-- 
To view, visit https://gerrit.osmocom.org/713
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I63dc0deaf15ba7c21e20b1e0c7b85f0437e183ed
Gerrit-PatchSet: 4
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list