libosmocore[master]: utils/conv_gen.py: don't mix print and write()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sun Oct 30 04:51:31 UTC 2016


Patch Set 1:

> As a general comment please include a "why" in commit messages. It
 > is clear that this helps with python3 support but is that the
 > intention of the change?

Right, it helps with python3 support, but it wasn't a primary aim.
There is also a problem with reduce(), which have to be imported
manually in python3. So, this change is mostly code style change.

I see two ways:
1) Leave this change as is (extending commit message), and import
   reduce() inside a new change like "enable python3 support".
2) Change the commit name to "enable python3 support", and import
   reduce exactly here.

What do you think?

-- 
To view, visit https://gerrit.osmocom.org/1164
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c8271d973f766aeb9cbcab30c4eddfdab54fcbb
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-HasComments: No



More information about the gerrit-log mailing list