This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (3 comments) Looks good. Thanks for adding many counters, some minor changes please. https://gerrit.osmocom.org/#/c/1167/1/src/tbf.cpp File src/tbf.cpp: Line 1004: bts->pkt_dl_assignemnt(); When is it NULL? Line 1079: bts->pkt_ul_assignment(); When is it NULL? https://gerrit.osmocom.org/#/c/1167/1/src/tbf_dl.cpp File src/tbf_dl.cpp: Line 652: coding_scheme = GprsCodingScheme::Scheme(cs); > separate function is preferred. yes -- To view, visit https://gerrit.osmocom.org/1167 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I605b0d66eb217decd35cbb8f87abfa577760245a Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: mrinal <mrinal.mishra at radisys.com> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes