[PATCH] libosmo-abis[master]: Extend RTP RX callback parameters

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Fri Oct 21 17:41:15 UTC 2016


Review at  https://gerrit.osmocom.org/1146

Extend RTP RX callback parameters

While debugging low-level RTP issues it is handy to be able to match
exact RTP packet with the payload available to higher-level
functions. Having Sequence number and Timestamp RTP fields as parameter
to receiving callback is the easiest way to do so.

Change-Id: I0c9b08d247d7342d6139badca77ce64fda0cf274
---
M TODO-RELEASE
M include/osmocom/trau/osmo_ortp.h
M src/trau/osmo_ortp.c
3 files changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/46/1146/1

diff --git a/TODO-RELEASE b/TODO-RELEASE
index 3af993e..128778a 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -1,3 +1,4 @@
 #library	what		description / commit summary line
 libosmo-abis	API change	major: add parameter to rx_cb() callack in osmo_ortp.h
 libosmo-abis	API change	major: add parameter to struct input_signal_data
+libosmo-abis	API change	major: add parameters to rx_cb() callack in osmo_ortp.h
diff --git a/include/osmocom/trau/osmo_ortp.h b/include/osmocom/trau/osmo_ortp.h
index 1c0b223..9eb176f 100644
--- a/include/osmocom/trau/osmo_ortp.h
+++ b/include/osmocom/trau/osmo_ortp.h
@@ -55,7 +55,8 @@
 
 	/*! \brief callback for incoming data */
 	void (*rx_cb)(struct osmo_rtp_socket *rs, const uint8_t *payload,
-		      unsigned int payload_len, bool marker);
+		      unsigned int payload_len, uint16_t seq_number,
+		      uint32_t timestamp, bool marker);
 
 	/*! \brief Receive user timestamp, to be incremented by user */
 	uint32_t rx_user_ts;
diff --git a/src/trau/osmo_ortp.c b/src/trau/osmo_ortp.c
index e3c6234..c756a9a 100644
--- a/src/trau/osmo_ortp.c
+++ b/src/trau/osmo_ortp.c
@@ -161,6 +161,8 @@
 		if (rs->rx_cb)
 			rs->rx_cb(rs, mblk->b_rptr,
 				  mblk->b_wptr - mblk->b_rptr,
+				  rtp_get_seqnumber(mblk),
+				  rtp_get_timestamp(mblk),
 				  rtp_get_markbit(mblk));
 		//rs->rx_user_ts += 160;
 		freemsg(mblk);

-- 
To view, visit https://gerrit.osmocom.org/1146
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c9b08d247d7342d6139badca77ce64fda0cf274
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list