[PATCH] libosmocore[master]: Revert "Constify ctrl_cmd struct fields where appropriate"

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Oct 20 15:59:17 UTC 2016


Review at  https://gerrit.osmocom.org/1121

Revert "Constify ctrl_cmd struct fields where appropriate"

This reverts commit ed9d6da5df98538adc70aa03cb569eb9505d04b6.

The commit is good as such, but it causes many compiler warnings in the OpenBSC
build. We want this to be re-applied as soon as we have patches ready that fix
the fallout in openbsc.git.

See also https://lists.osmocom.org/pipermail/openbsc/2016-October/009802.html

Related: OS#1829
Change-Id: I722ad60232a6ef5b4cb984b92c42851de26b3ccd
---
M TODO-RELEASE
M include/osmocom/ctrl/control_cmd.h
2 files changed, 3 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/21/1121/1

diff --git a/TODO-RELEASE b/TODO-RELEASE
index b67d6dd..648b6a6 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -4,4 +4,3 @@
 libosmocore	change major	size of ph_data_param struct changed / Extend L1SAP PH-DATA with presence information
 libosmocore	change major	size of ph_data_param struct changed / Extend L1SAP PH-DATA with measurement information
 libosmocore	change major	size of ph_tch_param struct changed / Extend with RTP Marker
-libosmocore	change minor	mark as const id, variable & value fields of ctrl_cmd struct
diff --git a/include/osmocom/ctrl/control_cmd.h b/include/osmocom/ctrl/control_cmd.h
index cd96038..8f2eaa2 100644
--- a/include/osmocom/ctrl/control_cmd.h
+++ b/include/osmocom/ctrl/control_cmd.h
@@ -53,10 +53,10 @@
 struct ctrl_cmd {
 	struct ctrl_connection *ccon;
 	enum ctrl_type type;
-	const char *id;
+	char *id;
 	void *node;
-	const char *variable;
-	const char *value;
+	char *variable;
+	char *value;
 	char *reply;
 };
 

-- 
To view, visit https://gerrit.osmocom.org/1121
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I722ad60232a6ef5b4cb984b92c42851de26b3ccd
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list