openggsn[master]: Only send TRAP for defined PDP peer

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Tue Oct 18 18:50:14 UTC 2016


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/1065/1/ggsn/ggsn.c
File ggsn/ggsn.c:

Line 146: 			LOGP(DGGSN, LOGL_ERROR, "Trap creation failed.\n");
"creation" but create+send is happening here? Please follow up to make this log message more expressive:

* Correct what was actually done!
* Mention the "peer" in the log message


-- 
To view, visit https://gerrit.osmocom.org/1065
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e02c1d42bb7aaf1ef81a9824aab7b12047cdd3e
Gerrit-PatchSet: 1
Gerrit-Project: openggsn
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list