This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/1060/1/src/hnbgw.c File src/hnbgw.c: Line 327: if (!g_hnb_gw->config.iuh_local_port) we normally solve such cases by initializing g_hnb_gw->config.iuh_local_port = IUH_DEFAULT_SCTP_PORT *before* reading the config file. This way we don't need some getter-function with conditionals, ... So basically, the typical solution applied in OpenBSC & co is exactly what you are removing here. I don't understand why? -- To view, visit https://gerrit.osmocom.org/1060 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b5e9fe9fcfa489069a0728d47899ef4a61f7ce5 Gerrit-PatchSet: 1 Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes