libosmocore[master]: gsm0408: Completing GSM 04.08 RR message types

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sun Oct 16 23:32:23 UTC 2016


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/1056/2/src/gsm/gsm48.c
File src/gsm/gsm48.c:

Line 165: const char *rr_cause_name(uint8_t cause)
So this function was previously already declared in gsm48.h but never defined? This fix should be in a separate commit, and the fix should also add rr_cause_name to the .map file. Since there are so far no callers, we might also want to rename it to gsm48_rr_cause_name while we still can? (All in a separate commit.)


Line 357: 	{ 0,				NULL }
I'd either drop the tabs or make it line up. This is neither...


-- 
To view, visit https://gerrit.osmocom.org/1056
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ceb070bf4dc8f5a071a5d43c6aa2d4e84c2dec6
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list