This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 4:
(3 comments)
https://gerrit.osmocom.org/#/c/503/4//COMMIT_MSG
Commit Message:
Line 18: Fix an issue and make the code worse. Assume ss_code > 0 to see if this
Make the code *worse*?? :)
So the commit log says "please reject me"?
https://gerrit.osmocom.org/#/c/503/4/openbsc/src/libmsc/ussd.c
File openbsc/src/libmsc/ussd.c:
Line 53: rc = gsm0480_decode_ss_request(gh, msgb_l3len(msg), &req);
I notice that decode_ussd_request also sets the ss.transaction_id, which decode_ss_request doesn't. It seems we're not using it anywhere though anyway. Just saying...
Line 61: if (req.ussd_text[0] == '\0') {
I see in decode_ussd_request this code:
if (ss.ussd_text[0] == 0xFF)
req->text[0] = '\0';
which is not present in decode_ss_request... where's the \0 coming from in decode_ss_?
case GSM0480_MTYPE_RELEASE_COMPLETE still sets ussd_text[0] = 0xFF; so below log will say "Unhandled USSD ÿ" with hopefully a nul term after the 'ÿ'?
--
To view, visit https://gerrit.osmocom.org/503
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0dc4485388f030eb172fe21f5327b7ab94751f5
Gerrit-PatchSet: 4
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes