This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 27: Code-Review+1 (1 comment) one last detail... https://gerrit.osmocom.org/#/c/416/26/src/egprs_rlc_compression.cpp File src/egprs_rlc_compression.cpp: Line 297: * \param orig_crbb_buf[in] Received block crbb bitmap > A one bit indicator I think the "starting" is a crucial part of the term. Please have 'starting' in the name. 'starting_color_code' IMHO is too long, I think I would actually call it 'start' and use your explanation in the comment; also, it is a bool so you should use 'true' and 'false': \param start[in] Starting Color Code, true if bitmap starts with a run length of ones, false if zeros. -- To view, visit https://gerrit.osmocom.org/416 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieae1992ed4b02bb1e09eec2d3de1a030eabd16ce Gerrit-PatchSet: 27 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: pravin <pravin.manoharan at radisys.com> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: pravin <pravin.manoharan at radisys.com> Gerrit-HasComments: Yes