This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 5: (5 comments) You may agree or not agree with my final style improvement. But please rebase onto master to clarify the parent commit. https://gerrit.osmocom.org/#/c/862/5//COMMIT_MSG Commit Message: Line 1: Parent: daa43f84 (Merge commit 'refs/changes/61/861/4' of https://gerrit.osmocom.org/osmo-pcu) the parent is a Merge-commit?? https://gerrit.osmocom.org/#/c/862/2/src/rlc.cpp File src/rlc.cpp: Line 108: unsigned num_blocks = rbb->cur_bit > (unsigned)distance() > What is meant is distance is guaranteed to be positive. since It seems to me then that distance() should return a uint16_t? https://gerrit.osmocom.org/#/c/862/5/src/rlc.cpp File src/rlc.cpp: Line 109: ? distance() : rbb->cur_bit; would make sense to call distance() only once ... but it's not really a performance burden in this case, just general style, to clearly show to the reader that the value is not intended to change between the comparison and setting it to num_blocks. You could use a uint with a comment: /* distance() is guaranteed to be positive because it does & mod_sns() */ uint16_t d = distance(); and then use 'd' to determine num_blocks. https://gerrit.osmocom.org/#/c/862/5/src/tbf_dl.cpp File src/tbf_dl.cpp: Line 851: ? m_window.distance() : num_blocks; (same) Line 931: ? m_window.distance() : rbb->cur_bit; (same) -- To view, visit https://gerrit.osmocom.org/862 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id07d178970f168f5389016c1eea31eb6b82057b6 Gerrit-PatchSet: 5 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes