This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 3: Code-Review-1 (4 comments) https://gerrit.osmocom.org/#/c/973/3//COMMIT_MSG Commit Message: Line 7: OML: Fixing static OML attribute tables This commit seems to do a whole lot more than fix some attribute tables. I think the commit log should mention added files and new unit tests, and possibly other things. Cosmetic: Let me comment once because you do this a lot: it's shorter to say "Fix static" than "Fixing static". The standard commit log form of grammar is the imperative, because it's the shortest: "add x", "fix y", "implement z". Line 9: - the OML attribute tables are hardcoded. To set variable parameters, interesting to have a bullet list with ... one bullet! https://gerrit.osmocom.org/#/c/973/3/openbsc/include/openbsc/Makefile.am File openbsc/include/openbsc/Makefile.am: Line 84: bts_ipaccess_nanobts_omlattr.h \ this list was sorted alphabetically before you add this line https://gerrit.osmocom.org/#/c/973/3/openbsc/src/libbsc/bts_ipaccess_nanobts_omlattr.c File openbsc/src/libbsc/bts_ipaccess_nanobts_omlattr.c: Line 3: /* (C) 2009-2010 by Harald Welte <laforge at gnumonks.org> Looks like this file is copied or moved from somewhere, how about mentioning that in the commit log? -- To view, visit https://gerrit.osmocom.org/973 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibeb34a84912d6cf695f553a34c69320fca7d08fa Gerrit-PatchSet: 3 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes