This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/1037/2/openbsc/src/libbsc/bsc_api.c File openbsc/src/libbsc/bsc_api.c: Line 642: case GSM48_MT_RR_UTRAN_CLSM_CHG: > We don't generally write this kind of copy+paste code. There should be one ok, so the old code also passes them along, sorry. then let's keep that. However, we should simply have one block of the code, including the "unknown" case. get_value_string() for an unknown/undefined value will automatically return an "unknown 0x%x" string. So all the newly-introduced cases and the AP_INFO and the default case can all be fall-through and handled by one block. -- To view, visit https://gerrit.osmocom.org/1037 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41f2242fdf59c3eb4b3f8f7f003c17f7e0df01aa Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes