openbsc[master]: gsm0408: Adding log output for 3g specific RR messages

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Oct 12 09:22:17 UTC 2016


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/1037/2/openbsc/src/libbsc/bsc_api.c
File openbsc/src/libbsc/bsc_api.c:

Line 642: 		case GSM48_MT_RR_UTRAN_CLSM_CHG:
We don't generally write this kind of copy+paste code.  There should be one block of LOGP and api->dtap sending. And the actual message name can be handled via a get_value_string() function call.  Also, all L3 message names are always written in upper case in all log output, please don't break that consistency.

Finally, the RR layer normally terminates at the BSC, only MM/CC/SMS are passed to the MSC.  Did you find anything in the specs about this particular RR messages being excempt from the general rule?


-- 
To view, visit https://gerrit.osmocom.org/1037
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41f2242fdf59c3eb4b3f8f7f003c17f7e0df01aa
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list