osmo-bts[master]: DTX DL: use FSM for AMR

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Oct 10 00:57:36 UTC 2016


Patch Set 2: Code-Review-1 Verified+1

I can confirm that this fixes voice for sysmoBTS using SDK 1.5.4,
so adding my V+1.

But your commit log is too sparse for this size of patch, and given
the situation:

You should include a hint at the fact that a regression introduced
by DTX is fixed by this, and do also explain at least briefly what
was wrong before.

I'd also welcome a summary of what the patch does in the files it
touches.

(The jenkins build failure is only due to the commit needed on openbsc,
that's why I can V+1 despite jenkins's V-1.)

-- 
To view, visit https://gerrit.osmocom.org/1030
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74a0b42cb34d525b8a70d264135e82994ca70d31
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list