osmo-pcu[master]: EGPRS: fix for EPDAN out of window

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

arvind.sirsikar gerrit-no-reply at lists.osmocom.org
Mon Oct 3 10:38:32 UTC 2016


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/#/c/862/4/src/tbf_dl.cpp
File src/tbf_dl.cpp:

Line 939: 
> I've tried for some minutes to understand, but I don't see it yet... why ca
We get the first_bsn as an argument, which is v_a.  In worst case, we calculate the num_blocks from v_a and v_s. which is inside the window. Hence we shall never enter this log section even during the worst case scenario, when epdan is out of RLC window. So removing this section of the code.

Let me know any other queries.


-- 
To view, visit https://gerrit.osmocom.org/862
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id07d178970f168f5389016c1eea31eb6b82057b6
Gerrit-PatchSet: 5
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list