libosmocore[master]: timer: only call the callback if not NULL

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Wed Nov 30 17:53:10 UTC 2016


Patch Set 1:

It would be good to see where it is crashing.

* Locally add an OSMO_ASSERT when registering the timer to see if the timer cb is set
* If it crashes at the dispatch we can still figure out "where" it was. The timer is embedded in a struct.. and talloc allows us to print the contexts and we should be able to figure out what happens.

Also -fsanitize=address (or valgrind) might be a good way to see if recently freed memory was accessed.

-- 
To view, visit https://gerrit.osmocom.org/1344
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04d58d9580708cc0f6d0f4aa17d3e9f2c6235c8e
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-HasComments: No



More information about the gerrit-log mailing list