osmo-bts[master]: Use system-installed pcuif_proto.h instead of local copy

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Nov 30 00:00:19 UTC 2016


Patch Set 3: Code-Review-1

(2 comments)

the osmo-bts build job is so far unable to build the new situation;
the easy way out would be to build with --disable-pcu-socket, but I think enabling would be better to catch build bugs. Taking a look at the build job now to accomodate this change...

https://gerrit.osmocom.org/#/c/1258/3/configure.ac
File configure.ac:

Line 118: 	AC_HELP_STRING([--distable-pcu-socket],
"distable" typo, which also causes this to not work
("configure: error: unrecognized option: `--distable-pcu-socket'")


Line 119: 		       [disable support for the PCU socket [default=yes]]),
at first I interpreted "default=yes" as "default is: yes, disable the support for PCU socket"; "default=enable" would be more clear


-- 
To view, visit https://gerrit.osmocom.org/1258
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd2537aeef60c7d154e90f279dc4e7c2392ff76
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list