This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
mrinal gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/1342 Add debugging log for RLC data block decoding Added debugging log for RLC UL Data Block decoding for both GPRS/EGPRS cases. Change-Id: I8c197bdc4cd1330cbab0adfd188336d27682cec4 --- M src/decoding.cpp M tests/tbf/TbfTest.err 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/42/1342/1 diff --git a/src/decoding.cpp b/src/decoding.cpp index 6ae4b16..0dbb10a 100644 --- a/src/decoding.cpp +++ b/src/decoding.cpp @@ -76,6 +76,9 @@ } else if (li->li == 127 && li->e == 1) { /* TS 44.060, table 10.4.14a.1, row 3 & 5 */ /* only filling bytes left */ + LOGP(DRLCMACUL, LOGL_DEBUG, "UL DATA LI contains " + "only filling bytes with extention octet: LI=%d, E=%d, count=%d\n", + li->li, li->e, num_chunks); break; } else if (li->li > 0) { /* TS 44.060, table 10.4.14a.1, row 1 & 2b */ @@ -88,6 +91,9 @@ return -EINVAL; } + LOGP(DRLCMACUL, LOGL_DEBUG, "UL DATA LI contains " + "extention octet: LI=%d, E=%d, count=%d\n", + li->li, li->e, num_chunks); num_chunks += 1; if (e == 1) { @@ -161,6 +167,9 @@ chunks[num_chunks].is_complete = li->li || is_last_block; + LOGP(DRLCMACUL, LOGL_DEBUG, "UL DATA LI contains " + "extention octet: LI=%d, M=%d, E=%d, count=%d\n", + li->li, li->m, li->e, num_chunks); num_chunks += 1; if (e == 1 && m == 1) { diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index a680812..2647551 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -6460,6 +6460,7 @@ - Raising V(R) to 2 - Taking block 1 out, raising V(Q) to 2 - Assembling frames: (len=44) +UL DATA LI contains extention octet: LI=0, E=1, count=0 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW EGPRS) complete UL frame len=44 LLC [PCU -> SGSN] TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW EGPRS) len=44 No bctx -- To view, visit https://gerrit.osmocom.org/1342 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8c197bdc4cd1330cbab0adfd188336d27682cec4 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: mrinal <mrinal.mishra at radisys.com>