[MERGED] openbsc[master]: abis_nm: ceck fseek() return code in is_last_line()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Nov 26 18:40:07 UTC 2016


Harald Welte has submitted this change and it was merged.

Change subject: abis_nm: ceck fseek() return code in is_last_line()
......................................................................


abis_nm: ceck fseek() return code in is_last_line()

Change-Id: I8ed4e703625c9da959e0938cd1eb3f0c73a2d4d0
Fixes: Coverity CID 57643
---
M openbsc/src/libbsc/abis_nm.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/libbsc/abis_nm.c b/openbsc/src/libbsc/abis_nm.c
index c9b2aac..0c723e8 100644
--- a/openbsc/src/libbsc/abis_nm.c
+++ b/openbsc/src/libbsc/abis_nm.c
@@ -838,7 +838,9 @@
 		return 1;
 
 	if (!fgets(next_seg_buf, sizeof(next_seg_buf)-2, stream)) {
-		fseek(stream, pos, SEEK_SET);
+		int rc = fseek(stream, pos, SEEK_SET);
+		if (rc < 0)
+			return rc;
 		return 1;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/1315
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8ed4e703625c9da959e0938cd1eb3f0c73a2d4d0
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list