This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 4: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/1268/4/openbsc/contrib/twisted_ipa.py File openbsc/contrib/twisted_ipa.py: Line 36: def ack(self): ping, pong and ACK are part of the CCM protocol, which is one user of the IPA multiplex. I don't think it belongs into the core class for the IPA multiplexer. Line 45: def ctrl_SET(self, data, op, v): control intreface functions/methods are specific to the control interface, which are again a completely different user of the IPA multiplex. Please separete out in an osmocom control protocol specific class. -- To view, visit https://gerrit.osmocom.org/1268 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07559df420b7fe8418f3412f45acd9a375e43bc5 Gerrit-PatchSet: 4 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes