osmo-pcu[master]: Handle packet access reject during packet resource request

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Thu Nov 17 14:49:10 UTC 2016


Patch Set 4: Code-Review-1

(1 comment)

Can you please describe the memory lifetime of this ad-hoc tbf? When will it be deleted? Can you test this in the testcase that there is no more tbf around?

https://gerrit.osmocom.org/#/c/1216/4/src/tbf.cpp
File src/tbf.cpp:

Line 1289: 	new (ul_tbf) gprs_rlcmac_ul_tbf(bts->bts);
Oh. I didn't notice you call the ctor here. But we can make it public. Nothing prevents us from doing that.


-- 
To view, visit https://gerrit.osmocom.org/1216
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05ff25124b58905586caa0c0c37023d69724f121
Gerrit-PatchSet: 4
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list