[PATCH] openbsc[master]: OM2000: Fixup based on Coverity Scan suggestion

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Tue Nov 15 18:30:53 UTC 2016


Review at  https://gerrit.osmocom.org/1250

OM2000: Fixup based on Coverity Scan suggestion

This commit fixes Coverity Scan defect:

CID 151901:  Insecure data handling  (TAINTED_SCALAR)
Passing tainted variable "tag_len" to a tainted sink.

Change-Id: Ic71ed6a3bbb228bc03e95bfc4a6f5fe09cf5a021
---
M openbsc/src/libbsc/abis_om2000.c
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/50/1250/1

diff --git a/openbsc/src/libbsc/abis_om2000.c b/openbsc/src/libbsc/abis_om2000.c
index 2733a90..7c2d754 100644
--- a/openbsc/src/libbsc/abis_om2000.c
+++ b/openbsc/src/libbsc/abis_om2000.c
@@ -2438,10 +2438,10 @@
 }
 
 /* Display fault report bits (helper function of display_fault_maps()) */
-static bool display_fault_bits(const uint8_t *vect, unsigned int len,
+static bool display_fault_bits(const uint8_t *vect, uint16_t len,
 			       uint8_t dei, const struct abis_om2k_mo *mo)
 {
-	int i;
+	unsigned int i;
 	int k;
 	bool faults_present = false;
 	int first = 1;

-- 
To view, visit https://gerrit.osmocom.org/1250
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic71ed6a3bbb228bc03e95bfc4a6f5fe09cf5a021
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>



More information about the gerrit-log mailing list