[PATCH] openbsc[master]: Add empty libcommon-cs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Nov 14 11:48:58 UTC 2016


Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/1123

to look at the new patch set (#3).

Add empty libcommon-cs

This will gradually soak up code shared by libbsc and libmsc.

Change-Id: If34e2bd38a099d0799238337468d56e0305ab8ae
---
M openbsc/configure.ac
M openbsc/include/openbsc/Makefile.am
A openbsc/include/openbsc/common_cs.h
M openbsc/src/Makefile.am
A openbsc/src/libcommon-cs/Makefile.am
A openbsc/src/libcommon-cs/common_cs.c
A openbsc/src/libcommon-cs/common_cs_vty.c
7 files changed, 62 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/23/1123/3

diff --git a/openbsc/configure.ac b/openbsc/configure.ac
index b18ecc1..093d42f 100644
--- a/openbsc/configure.ac
+++ b/openbsc/configure.ac
@@ -214,6 +214,7 @@
     src/libcommon/Makefile
     src/libfilter/Makefile
     src/libiu/Makefile
+    src/libcommon-cs/Makefile
     src/osmo-nitb/Makefile
     src/osmo-bsc/Makefile
     src/osmo-bsc_nat/Makefile
diff --git a/openbsc/include/openbsc/Makefile.am b/openbsc/include/openbsc/Makefile.am
index 5737a4b..d9d8e99 100644
--- a/openbsc/include/openbsc/Makefile.am
+++ b/openbsc/include/openbsc/Makefile.am
@@ -13,6 +13,7 @@
 	bss.h \
 	bts_ipaccess_nanobts_omlattr.h \
 	chan_alloc.h \
+	common_cs.h \
 	crc24.h \
 	ctrl.h \
 	db.h \
diff --git a/openbsc/include/openbsc/common_cs.h b/openbsc/include/openbsc/common_cs.h
new file mode 100644
index 0000000..6f70f09
--- /dev/null
+++ b/openbsc/include/openbsc/common_cs.h
@@ -0,0 +1 @@
+#pragma once
diff --git a/openbsc/src/Makefile.am b/openbsc/src/Makefile.am
index 272292a..cfad7df 100644
--- a/openbsc/src/Makefile.am
+++ b/openbsc/src/Makefile.am
@@ -27,6 +27,7 @@
 	libmsc \
 	libtrau \
 	libfilter \
+	libcommon-cs \
 	$(NULL)
 
 # Conditional Libraries
diff --git a/openbsc/src/libcommon-cs/Makefile.am b/openbsc/src/libcommon-cs/Makefile.am
new file mode 100644
index 0000000..f3921ba
--- /dev/null
+++ b/openbsc/src/libcommon-cs/Makefile.am
@@ -0,0 +1,20 @@
+AM_CPPFLAGS = \
+	$(all_includes) \
+	-I$(top_srcdir)/include \
+	-I$(top_builddir) \
+	$(NULL)
+
+AM_CFLAGS = \
+	-Wall \
+	$(LIBOSMOCORE_CFLAGS) \
+	$(LIBOSMOGSM_CFLAGS) \
+	$(LIBOSMOVTY_CFLAGS) \
+	$(LIBOSMOABIS_CFLAGS) \
+	$(COVERAGE_CFLAGS) \
+	$(NULL)
+
+noinst_LIBRARIES = libcommon-cs.a
+
+libcommon_cs_a_SOURCES = \
+	common_cs.c \
+	common_cs_vty.c
diff --git a/openbsc/src/libcommon-cs/common_cs.c b/openbsc/src/libcommon-cs/common_cs.c
new file mode 100644
index 0000000..99aa0cf
--- /dev/null
+++ b/openbsc/src/libcommon-cs/common_cs.c
@@ -0,0 +1,19 @@
+/* Code used by both libbsc and libmsc (common_cs means "BSC or MSC").
+ *
+ * (C) 2016 by sysmocom s.m.f.c. <info at sysmocom.de>
+ * All Rights Reserved
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
diff --git a/openbsc/src/libcommon-cs/common_cs_vty.c b/openbsc/src/libcommon-cs/common_cs_vty.c
new file mode 100644
index 0000000..99aa0cf
--- /dev/null
+++ b/openbsc/src/libcommon-cs/common_cs_vty.c
@@ -0,0 +1,19 @@
+/* Code used by both libbsc and libmsc (common_cs means "BSC or MSC").
+ *
+ * (C) 2016 by sysmocom s.m.f.c. <info at sysmocom.de>
+ * All Rights Reserved
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */

-- 
To view, visit https://gerrit.osmocom.org/1123
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If34e2bd38a099d0799238337468d56e0305ab8ae
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list