This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.org
Patch Set 2:
(4 comments)
Nice! where do we use SOL_PACKET? And FreeBSD portability is no concern.. we just disable/fail if somebody tries that on FreeBSD
https://gerrit.osmocom.org/#/c/1198/2/src/input/unixsocket.c
File src/input/unixsocket.c:
Line 68: ret = read(bfd->fd, msg->data, UNIXSOCKET_ALLOC_SIZE - 16);
Why -16? your msgb doesn't have any headroom anyway?
Line 73: perror("read ");
doesn't end up in the logging framework. socket, ret, errno would be good in a commit message
Line 112: LOGP(DLINP, LOGL_INFO, "unixsocket: sending: %s", msgb_hexdump(msg));
obviously reduce log level in the future
Line 161: const char *sock_path = "/tmp/rsl_oml";
We have precedence with mncc but /tmp is a "free for all" place and we would need to think of permissions.. and running two in parallel? Would an abstract socket help?
--
To view, visit https://gerrit.osmocom.org/1198
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5723b09a5c68a0505829dc732def981e60a907a
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-HasComments: Yes