[PATCH] openbsc[master]: RBS2000: Ensure the is-connection-list command is only used ...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Nov 11 20:21:22 UTC 2016


Review at  https://gerrit.osmocom.org/1239

RBS2000: Ensure the is-connection-list command is only used on RBS2000

... and not on other BTS models.

Change-Id: I8882ca9a9ab974b0bbdcbd5c3bab0eadf4bc0927
---
M openbsc/src/libbsc/abis_om2000_vty.c
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/39/1239/1

diff --git a/openbsc/src/libbsc/abis_om2000_vty.c b/openbsc/src/libbsc/abis_om2000_vty.c
index d48ff95..64d205c 100644
--- a/openbsc/src/libbsc/abis_om2000_vty.c
+++ b/openbsc/src/libbsc/abis_om2000_vty.c
@@ -348,6 +348,12 @@
 	uint8_t ci = atoi(argv[3]);
 	struct is_conn_group *grp, *grp2;
 
+	if (bts->type != GSM_BTS_TYPE_RBS2000) {
+		vty_out(vty, "%% IS MO only exists in RBS2000%s",
+			VTY_NEWLINE);
+		return CMD_WARNING;
+	}
+
 	if (!strcmp(argv[0], "add")) {
 		grp = talloc_zero(bts, struct is_conn_group);
 		grp->icp1 = icp1;

-- 
To view, visit https://gerrit.osmocom.org/1239
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8882ca9a9ab974b0bbdcbd5c3bab0eadf4bc0927
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list