This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pravin gerrit-no-reply at lists.osmocom.orgPatch Set 4: > See previous two rounds of critical things not addressed. > > * No testcase > * Side-effect of curbit being incremented not documented (and why > should there be a side effect) > * Not all parameters documented > * Code duplication for actual matching.. Testcase is added as a part of Tbftest.cpp file in osmo-pcu and that patch is under https://gerrit.osmocom.org/#/c/414/ I will do documentation for max_bits. For curbit I have documented (cur_bit will go to cur_bit + number of consecutive bit). What do you mean by Code duplication for actual matching ? will you please point it out. Thanks Pravin -- To view, visit https://gerrit.osmocom.org/415 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae153d3639ea6b891c1fc10d7801a435c9492e26 Gerrit-PatchSet: 4 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: prasadkg <Prasad.Kaup at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: prasadkg <Prasad.Kaup at radisys.com> Gerrit-Reviewer: pravin <pravin.manoharan at radisys.com> Gerrit-HasComments: No