osmo-gsm-manuals[master]: Documentation on AMR RTP in case of DTX

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Nov 3 11:47:01 UTC 2016


Patch Set 2: Code-Review-1

(1 comment)

Fixed numerous typos / stylos, but this will create conflicts due to the way these patches are submitted. IMHO if a given file is known to belong in a different directory at time of patch submission, it makes sense to rebase the changes so that the first patch already has the correct location. Also, rtp-amr.doc is apparently at first added dangling, i.e. not actually included in any PDF output.

I'm aware that it might be a time optimisation choice to not comb the commits before submitting for review, but in this case it might backfire by complicating the review process.

marking -1 because of the question on line 54

https://gerrit.osmocom.org/#/c/1185/2/OsmoBTS/abis/rtp-amr.adoc
File OsmoBTS/abis/rtp-amr.adoc:

Line 54: related bursts have been received:
missing list of primitives?


-- 
To view, visit https://gerrit.osmocom.org/1185
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I394f405b441c1eb000759151bd8350d5b3a84a0b
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list