openbsc[master]: pcu_if: original pcu sock interface from osmo-bts

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Nov 2 13:24:30 UTC 2016


Patch Set 3:

> c) have one copy of the code (e.g. in the BSC) and pull the source
 > into the BTS, like we do with gsm_data_shared.  Not elegant, but as
 > we already do it in one place, might not hurt to do more of that.

IMHO this would be the point where we should rather solve this properly. Including gsm_data_shared.h from osmo-bts is and always has been ugly, as far as I'm concerned. It's the only place where we include a c file from another source tree, instead of using things that are installed. If I checkout another branch without doing 'make install', I expect that to not affect any other code trees... my two cents.

-- 
To view, visit https://gerrit.osmocom.org/1169
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46b0a65f1633c40053d43b57b786b042f20f12bd
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list