osmo-pcu[master]: Refactoring write_packet_ack_nack_desc_egprs to support CRBB

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Wed Nov 2 10:31:14 UTC 2016


Patch Set 4:

(2 comments)

https://gerrit.osmocom.org/#/c/412/4//COMMIT_MSG
Commit Message:

Line 7: Refactoring write_packet_ack_nack_desc_egprs to support CRBB
CRBB is not supported by this patch yet. So maybe say prepare for CRBB support?


https://gerrit.osmocom.org/#/c/412/4/src/encoding.cpp
File src/encoding.cpp:

Line 335: 		bitvec_write_field(dest, wp, tbf->current_cs().to_num()-1, 2); // CHANNEL_CODING_COMMAND
even if the coding style is violated in the existing file, please do not modify.. it just creates noise.


-- 
To view, visit https://gerrit.osmocom.org/412
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5c25b6ee30f2f1b613e923c234b03a6ffe12ae2
Gerrit-PatchSet: 4
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: prasadkg <Prasad.Kaup at radisys.com>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: prasadkg <Prasad.Kaup at radisys.com>
Gerrit-Reviewer: pravin <pravin.manoharan at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list