libosmocore[master]: Add function to get uninterrupted bit run Function bitv...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Wed Nov 2 09:31:28 UTC 2016


Patch Set 3: Code-Review-1

(5 comments)

Still lacks a testcase.

https://gerrit.osmocom.org/#/c/415/3/src/bitvec.c
File src/bitvec.c:

Line 581:  * \param[in] b The boolean, sequence of 1's or 0's to be checked
max_bits is not documented


Line 582:  * \returns Number of consecutive bits of \p b in \p bv
This doesn't mention that cur_bit will go up.


Line 590: 	if (bv->cur_bit % 8 == 0) {
Can't you re-order the code to first read up to a full byte.. and then do the byte aligned handling.


Line 592: 				i < (max_bits % 8 ? max_bits/8 + 1 : max_bits/8);
select the mask once.. max_bits should not change during the call.


Line 594: 			if ((b ? 0xFF : 0) != bv->data[i]) {
select the bytemask once in the beginning


-- 
To view, visit https://gerrit.osmocom.org/415
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae153d3639ea6b891c1fc10d7801a435c9492e26
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: prasadkg <Prasad.Kaup at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: prasadkg <Prasad.Kaup at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list