This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 8: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/862/8/src/rlc.cpp File src/rlc.cpp: Line 109: unsigned dist = (unsigned)distance(); Sorry two parts. I said drop the cast (speciall c casts). int16_t -> unsigned is something that works without warning (and we assume unsigned is at least 32bits) Second part. If you have to write it into a comment, then let's change the return value of distance? So besides the technical mod_sns() we assume that m_v_s is always bigger/equal than m_v_a (send, bigger than acked). Sounds right to me? This comment applies to the other places as well. -- To view, visit https://gerrit.osmocom.org/862 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id07d178970f168f5389016c1eea31eb6b82057b6 Gerrit-PatchSet: 8 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes