This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/1179/1/openbsc/src/libbsc/abis_rsl.c File openbsc/src/libbsc/abis_rsl.c: Line 115: LOGP(DRSL, LOGL_DEBUG, "count_codecs unknown lchan->type %s on channel %s\n", At first it seems that the ERROR level is a good choice, but in fact count_codecs() is called on every chan act ack, also for channels other than TCH/F and TCH/H. So this logging apparently happens a lot during normal operation. I would favor to drop this logging altogether, at least put it in another logging category (RSL is about the RSL communications, not whether our internal code tries to count lchan codecs for the wrong channel types). Anyway, this patch is an improvement. -- To view, visit https://gerrit.osmocom.org/1179 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11b04e0cb02bf6ed01f6076cb31a56d8921d735e Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes