openbsc[master]: Make random MSISDN assignment optional

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Thu Jun 30 19:01:18 UTC 2016


Patch Set 7:

(2 comments)

Code looks good. One question about the test and what is being tested.

https://gerrit.osmocom.org/#/c/201/7/openbsc/tests/vty_test_runner.py
File openbsc/tests/vty_test_runner.py:

Line 424:         res = self.vty.command("subscriber-create-on-demand random 221 122")
so this tests a wrong interval can be set?


Line 428:         self.assertTrue(self.vty.verify("subscriber-create-on-demand random 221 222", ['']))
nothing tested here?


-- 
To view, visit https://gerrit.osmocom.org/201
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbc2e88e4722b08854ebc631485f19ed56443cbb
Gerrit-PatchSet: 7
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list