[MERGED] libosmocore[master]: Clarify GPRS ciphering direction

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Jun 29 16:33:57 UTC 2016


Harald Welte has submitted this change and it was merged.

Change subject: Clarify GPRS ciphering direction
......................................................................


Clarify GPRS ciphering direction

Add spec reference and set explicit values for enum representing
direction parameter for GPRS encryption.

Change-Id: Iaf1b13da2e889d55cc9dd7516710104dba48c992
Related: OS#1582
---
M include/osmocom/crypt/gprs_cipher.h
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/crypt/gprs_cipher.h b/include/osmocom/crypt/gprs_cipher.h
index 9d98f88..2639293 100644
--- a/include/osmocom/crypt/gprs_cipher.h
+++ b/include/osmocom/crypt/gprs_cipher.h
@@ -14,9 +14,10 @@
 	_GPRS_ALGO_NUM
 };
 
+/* 3GPP TS 04.64 Table A.1: */
 enum gprs_cipher_direction {
-	GPRS_CIPH_MS2SGSN,
-	GPRS_CIPH_SGSN2MS,
+	GPRS_CIPH_MS2SGSN = 0,
+	GPRS_CIPH_SGSN2MS = 1,
 };
 
 extern const struct value_string gprs_cipher_names[];

-- 
To view, visit https://gerrit.osmocom.org/423
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf1b13da2e889d55cc9dd7516710104dba48c992
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list