osmo-bts[master]: Update parameters in osmo-bts for 11 bit RACH

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Jun 29 16:30:20 UTC 2016


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/434/1/src/osmo-bts-sysmo/l1_if.c
File src/osmo-bts-sysmo/l1_if.c:

Line 963: 		LOGP(DL1P, LOGL_DEBUG, " 0th byte :%d \n and 1st byte: %d \n",
please remove those debug messages. I think they're quite a bit too low level and are probably not needed after your initial testing/development.  L1P debugging already will print us the hexdump of the primitive, and GSMTAP will probbly  also generate a wireshark-parseable prtoocol trace.  There can be many rach requests processed, so better not spend too much time in printf() for each of them. Also, the old code didn't do any logging either...


-- 
To view, visit https://gerrit.osmocom.org/434
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93831ddfb3f31b637e6a576f23a9bb4557758582
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list