This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/436/1/openbsc/include/openbsc/gsm_data_shared.h File openbsc/include/openbsc/gsm_data_shared.h: Line 693: uint8_t is_11bit_rach; naming: I think has_11bit_rach or supports_11bit_rach is better than "is". Neither the BTS nor the SI "is" a RACH. https://gerrit.osmocom.org/#/c/436/1/openbsc/src/libbsc/bsc_vty.c File openbsc/src/libbsc/bsc_vty.c: Line 448: vty_out(vty, " eleven_bit_rach_support%s", so you write some parameter when saving the file, butI don't see you add any VTY code to parse the file. did you try saving the config file and re-starting the BSC with the file you just saved? I think it will refuse to start due to syntax errors. -- To view, visit https://gerrit.osmocom.org/436 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51357bec936c28a26ab9ff5d59e0e30ca3363297 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes