This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/334/1/src/tbf_dl.cpp File src/tbf_dl.cpp: Line 379: m_rlc.block(bsn)->cs_current_trans = See the previous commit. I would prefer that this is a setter instead of accessing it directly Line 389: /* TODO: Need to remove this check when MCS-8 -> MCS-6 Maybe a single sentence of what is involved in that case? Line 627: cs = m_rlc.block(index)->cs_current_trans; maybe as a general stratgey let's rename the cs field of the struct so we catch _all_ old usages? -- To view, visit https://gerrit.osmocom.org/334 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a845c98f2018795f0f62240f228411b0bc030c7 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes