osmo-bts[master]: sysmo: add L3 handle to l1prim messages

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Thu Jun 16 14:08:45 UTC 2016


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/264/2/src/osmo-bts-sysmo/l1_if.c
File src/osmo-bts-sysmo/l1_if.c:

Line 143: 	return 0;
> It would be nice if '0' wouldn't be a legal hLayer3 handle.
The reason is that '0' is a valid BTS Nr, TRX Nr, TS NO, Lchan Num.  So you can not  distinguish zero initialized, zero default from valid lchan?

I would have sacrificed the limit of 256 BTS and set the MSB to distinguish valid from invalid numbers.


-- 
To view, visit https://gerrit.osmocom.org/264
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4533c6cbc160318917e7a672ab6f9a848f01d1b
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list