This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/267/3/openbsc/src/libcommon/gsm_data_shared.c File openbsc/src/libcommon/gsm_data_shared.c: Line 95: /* TODO: move to libosmocore, next to gsm_chan_t_names? */ > I think both comment and gsm_lchant_name() wrapper can be removed: we can u we often have gsm_foo_name() functions to help in constructing log messages. I want to keep gsm_chant_name() just like gsm_lchan_name(), gsm_chans_name(), gsm_pchan_name()... Ususally the gsm_foo_name() is right next to the value strings array (if it uses one). The gsm_lchant_name() is different for hysterical raisins, because for some odd reason it wasn't added in libosmocore in the first place. I was lazy and wanted to avoid pushing a change to libosmocore and openbsc for now, since one of them would definitely be rejected by the jenkins build. Hence the comment. I want to keep the comment as well. -- To view, visit https://gerrit.osmocom.org/267 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If65ee7c0619cbc0acb0a15045bd5a969442c93cc Gerrit-PatchSet: 3 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes