This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/270/1/src/bts.h File src/bts.h: PS1, Line 191: 9 Don't we already have a #define somewhere that allows us to avoid magic numbers but have a NR_GPRS_CS or similar here? If not, please introduce it. https://gerrit.osmocom.org/#/c/270/1/src/gprs_ms.cpp File src/gprs_ms.cpp: PS1, Line 635: 9 same here, let's use a #define. If it would have been used in the old code, we would have had only to change one location in the code, rather than various occurrences of the magic number '4'. -- To view, visit https://gerrit.osmocom.org/270 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13c250e2e07377982ac3f29745f3cffd4088552a Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes