This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/244/1/src/osmo-bts-litecell15/oml.c File src/osmo-bts-litecell15/oml.c: PS1, Line 798: failure_rep.event_type = NM_EVT_PROC_FAIL; : failure_rep.event_serverity = NM_SEVER_CRITICAL; : failure_rep.cause_type = NM_PCAUSE_T_MANUF; : failure_rep.event_cause = NM_MM_EVT_CRIT_SW_FATAL; : failure_rep.add_text = (char *)&log_msg; you introduce several blocks like this in your patch series, I think it would be better to introduce a common function to which the MO and the individual arguments are passed, and which then wraps the call to oml_tx_failure_event_rep(). Or possibly even change the signature of that function to do away with struct gsm_failure_evt_rep? -- To view, visit https://gerrit.osmocom.org/244 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic19e21c31a8f95c5e15c91cd886788ec4e83ec13 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-HasComments: Yes