This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.org
Patch Set 1:
(3 comments)
https://gerrit.osmocom.org/#/c/239/1/include/osmo-bts/gsm_data.h
File include/osmo-bts/gsm_data.h:
PS1, Line 114: #ifdef ENABLE_LC15BTS
: /* specific to LC15 BTS */
: uint8_t max_cell_size; /* 166 qbits */
: uint8_t diversity_mode; /* 0: SISO A, 1: SISO B, 2: MRC */
: uint8_t pedestal_mode; /* 0: unused TS is OFF, 1: unused TS is in minimum Tx power */
: uint8_t tx_pwr_adj_mode; /* 0: no auto adjust power, 1: auto adjust power using RMS detector */
: uint8_t tx_pwr_red_8psk; /* 8-PSK maximum Tx power reduction level in dB */
: #endif
: };
we don't have any bts-model specific values in this structure so far, and I'm not convinced this is the right place to store this data. Wouldn't it make more sense in the phy_link?
Also, if it must be introduced here, then it should be a sub-structure like struct { .... } lc15;
https://gerrit.osmocom.org/#/c/239/1/src/osmo-bts-litecell15/lc15bts.h
File src/osmo-bts-litecell15/lc15bts.h:
PS1, Line 81: SM_BTS_M
as far as i can see, all these constants are LC15 specific, so they should probably not have the generic GSM_BTS_ prefix, but something that indicates they are LC15.
https://gerrit.osmocom.org/#/c/239/1/src/osmo-bts-litecell15/lc15bts_vty.c
File src/osmo-bts-litecell15/lc15bts_vty.c:
Line 354: "max-cell-size <0-166>",
you introduce a lot of configuration locally to the BTS. This is quite contrary to the classic GSM architecture approach where all configuration is down-loaded via A-bis OML from the BSC, and related configuration is at the BSC.
I'm not fundamentally against doing it this way, but your approach using the bts-local configuration file basically makes the configuration management of larger BTS populations much more complicated, as the operator will have to build a configuration and cofnig version management system for config files on all BTSs, as opposed to just one central at the BSC.
If you look at the OML of Nokia/Ericsson/Siemens, these kind of settings are all part of their respective OML dialects.
--
To view, visit https://gerrit.osmocom.org/239
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3622d5b6f22525b798b0c75bbc2bab3767aba923
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-HasComments: Yes