This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Minh-Quang Nguyen gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/253 LC15: common/oml.c: Alarm - Unsupported radio attributes Change-Id: I209ea1ca0b54fb36189ca1154134344f57c1898c --- M src/common/oml.c 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/53/253/1 diff --git a/src/common/oml.c b/src/common/oml.c index ccafc66..cc87ec4 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -676,13 +676,25 @@ struct abis_om_fom_hdr *foh = msgb_l3(msg); struct tlv_parsed tp, *tp_merged; int rc; + char log_msg[100]; + struct gsm_failure_evt_rep failure_rep; abis_nm_debugp_foh(DOML, foh); DEBUGPC(DOML, "Rx SET RADIO CARRIER ATTR\n"); rc = oml_tlv_parse(&tp, foh->data, msgb_l3len(msg) - sizeof(*foh)); - if (rc < 0) + if (rc < 0) { + snprintf(log_msg, 100, "New value for Set Radio Attribute not supported\n"); + LOGP(DOML, LOGL_NOTICE,"%s", log_msg); + failure_rep.event_type = NM_EVT_PROC_FAIL; + failure_rep.event_serverity = NM_SEVER_MAJOR; + failure_rep.cause_type = NM_PCAUSE_T_MANUF; + failure_rep.event_cause = NM_MM_EVT_MAJ_UNSUP_ATTR; + failure_rep.add_text = (char *)&log_msg; + + oml_tx_failure_event_rep(&trx->mo, failure_rep); return oml_fom_ack_nack(msg, NM_NACK_INCORR_STRUCT); + } /* merge existing BTS attributes with new attributes */ tp_merged = tlvp_copy(trx->mo.nm_attr, trx->bts); -- To view, visit https://gerrit.osmocom.org/253 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I209ea1ca0b54fb36189ca1154134344f57c1898c Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>