[PATCH] osmo-pcu[master]: tbf_dl: correct tbf name in log message for moving a DL TBF

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Fri Jun 10 11:12:58 UTC 2016


Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/212

to look at the new patch set (#2).

tbf_dl: correct tbf name in log message for moving a DL TBF

It makes no sense to call functions on null pointer object. Use
the name of the old tbf.

Change-Id: I93b8c07a0b2de40a11e94fd6c212897cbe3b50ef
---
M src/tbf_dl.cpp
M tests/tbf/TbfTest.err
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/12/212/2

diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp
index 5931676..9dd4bfc 100644
--- a/src/tbf_dl.cpp
+++ b/src/tbf_dl.cpp
@@ -214,7 +214,7 @@
 				LOGP(DRLCMAC, LOGL_NOTICE,
 					"%s IMSI %s: "
 					"moving DL TBF to new MS object\n",
-					dl_tbf->name(), imsi);
+					ms_old->dl_tbf()->name(), imsi);
 				dl_tbf = ms_old->dl_tbf();
 				/* Move the DL TBF to the new MS */
 				dl_tbf->set_ms(ms);
diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err
index 9bea2fd..4e83ce2 100644
--- a/tests/tbf/TbfTest.err
+++ b/tests/tbf/TbfTest.err
@@ -1868,7 +1868,7 @@
 - No gaps in received block, last block: BSN=0 CV=15
 Old MS: TLLI = 0xf1223344, TA = 7, IMSI = 0011223344, LLC = 0
 There is a new MS object for the same MS: (0xf1223344, '0011223344') -> (0xf5667788, '')
-(no TBF) IMSI 0011223344: moving DL TBF to new MS object
+TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=FINISHED) IMSI 0011223344: moving DL TBF to new MS object
 Detaching TBF from MS object, TLLI = 0xf1223344, TBF = TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=FINISHED)
 Attaching TBF to MS object, TLLI = 0xf5667788, TBF = TBF(TFI=0 TLLI=0xf5667788 DIR=DL STATE=FINISHED)
 Modifying MS object, TLLI = 0xf5667788, IMSI '' -> '0011223344'

-- 
To view, visit https://gerrit.osmocom.org/212
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I93b8c07a0b2de40a11e94fd6c212897cbe3b50ef
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list