osmo-bts[master]: Move common TCH code into src/common/tch.c

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Jun 7 15:28:32 UTC 2016


Patch Set 2: Code-Review-1

The problem I see with this to some extent is that there is some commonality between osmo-bts-sysmo and osmo-bts-lc15, but not with other BTS models.  So at the very leas the code should have very clearly documented about which type of hardware it applies to.

In general, I'm not quite happy with this.  As stated before, there is no guarantee that lc15 and sysmobts will not diverge more over time, and then we'd have to split up the 'common' code again.  I think for now it's best to get over it and do changes in both BTS back-ends.

-- 
To view, visit https://gerrit.osmocom.org/206
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0d4d0f9848fc2ab54f975a3b6d1815fbcdf78a7
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list