This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.org
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/215/1/src/osmo-bts-litecell15/tch.c
File src/osmo-bts-litecell15/tch.c:
PS1, Line 103: set_payload_size
as the functions are non-static and added to tch.c, I would expect their name to be more descriptive. "set_payload_type()" doesn't give any indication that it is about tch type. So maybe tch_{set,get}_payload_{type,addr} would be more descriptive
--
To view, visit https://gerrit.osmocom.org/215
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie36b6d7a32cd3eaeb09f5a60c1a6471516a61fbd
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes