This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (1 comment) I would have preferred not to mix the min/max handling make MSISDN optional as they have little to do with each other. I was willing to look away but there is something else I don't find right so please split up, bool ext = (GSM_SUBSCR_CREAT_W_RAND_EXT == gsmnet->subscr_creation_mode) ? true : false; we have this snippet at three or more places. This show an issue. Can you centralize the creation? https://gerrit.osmocom.org/#/c/201/1/openbsc/src/libcommon/gsm_subscriber_base.c File openbsc/src/libcommon/gsm_subscriber_base.c: Line 66: s->extension[0] = '\0'; Okay but we can rely on talloc_zero :) -- To view, visit https://gerrit.osmocom.org/201 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbc2e88e4722b08854ebc631485f19ed56443cbb Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes