osmo-bts[master]: Use libosmocodec for AMR RTP

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Jun 6 21:39:47 UTC 2016


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/204/2//COMMIT_MSG
Commit Message:

Line 9: Add dependency on libosmocodec and use it to parse RTP with AMR payload.
now "add dependency" isn't accurate :)

could you explain in more detail, you're adding libosmocodec linking flags for which program(s) exactly?

Also I would appreciate some words on the aim. The current log message makes me (with no idea what AMR is) think this adds the capability to talk a kind of encoding language osmo-bts couldn't handle before. When looking at the code it looks more like it's about some AMR parameters extracted in a better way?


https://gerrit.osmocom.org/#/c/204/2/src/osmo-bts-sysmo/tch.c
File src/osmo-bts-sysmo/tch.c:

Line 326: 	int8_t sti, cmi;
(not really important, but would be nice to avoid cosmetic reordering like this)


-- 
To view, visit https://gerrit.osmocom.org/204
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1464f9a12e3f92926d03d5dd5d18e8f0f7206dd9
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list