osmo-bts[master]: Move TCH code to common subdir

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Jun 6 16:29:00 UTC 2016


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/206/1//COMMIT_MSG
Commit Message:

Line 7: Move TCH code to common subdir
the summary omits one of the two changes.
I'd actually prefer to have this in two separate commits...


https://gerrit.osmocom.org/#/c/206/1/src/osmo-bts-litecell15/tch.c
File src/osmo-bts-litecell15/tch.c:

Line 103: void set_payload_size(struct msgb *msg, uint8_t size)
no-one is using these functions? they are not published in any .h file?

At least explain in the commit log who will use them
... and how :)


https://gerrit.osmocom.org/#/c/206/1/src/osmo-bts-sysmo/tch.c
File src/osmo-bts-sysmo/tch.c:

Line 92: void set_payload_size(struct msgb *msg, uint8_t size)
same thing: no users?


-- 
To view, visit https://gerrit.osmocom.org/206
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0d4d0f9848fc2ab54f975a3b6d1815fbcdf78a7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list